Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scipy solve allows more assume_a flags in 1.15 #1152

Open
ricardoV94 opened this issue Jan 13, 2025 · 0 comments
Open

Scipy solve allows more assume_a flags in 1.15 #1152

ricardoV94 opened this issue Jan 13, 2025 · 0 comments
Labels

Comments

@ricardoV94
Copy link
Member

Description

https://docs.scipy.org/doc/scipy-1.15.0/reference/generated/scipy.linalg.solve.html

The default is no longer gen, scipy evaluates the matrix to decide which type to use. This led to a failing test, but more importantly we should consider allowing some of the new flags

@ricardoV94 ricardoV94 changed the title Scipy solve allows more flags in 1.15 Scipy solve allows more assume_a flags in 1.15 Jan 13, 2025
ricardoV94 added a commit to ricardoV94/pytensor that referenced this issue Jan 13, 2025
CholSolve outputs a different dtype than basic Solve in Scipy==1.15

Tweaked test related to pymc-devs#1152
ricardoV94 added a commit to ricardoV94/pytensor that referenced this issue Jan 13, 2025
1. Use actual Solve Op to infer output dtype as CholSolve outputs a different dtype than basic Solve in Scipy==1.15

2. Tweaked test related to pymc-devs#1152

3. Tweak tolerage
ricardoV94 added a commit that referenced this issue Jan 13, 2025
1. Use actual Solve Op to infer output dtype as CholSolve outputs a different dtype than basic Solve in Scipy==1.15

2. Tweaked test related to #1152

3. Tweak tolerage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant