Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow each input to have one upstream connection #502

Open
liamhuber opened this issue Nov 21, 2024 · 0 comments
Open

Only allow each input to have one upstream connection #502

liamhuber opened this issue Nov 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@liamhuber
Copy link
Member

This should make the graph more reliable, and -- together with always pulling upstream data -- this should close #498.

The only real con I see is that then we need to rework the Channel architecture a little, since Input.connections and Output.connections would no longer be so similar, but rather we'd have the singular Input.connection.

Depends on #501, because currently the attack for while loops depends on having multiple inputs with different priority. AFAIK this is the only place that functionality is actually leveraged, but making the change and running the test suite will tell if my memory is right on that.

@liamhuber liamhuber added the enhancement New feature or request label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant