Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow continuing after failure in for-loops #397

Open
liamhuber opened this issue Jul 31, 2024 · 4 comments
Open

Allow continuing after failure in for-loops #397

liamhuber opened this issue Jul 31, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@liamhuber
Copy link
Member

I.e. if one or more children in the For-macro fail, just log their output as NOT_DATA and keep going. Should be optional, and I'm comfortable making it default to True.

@liamhuber liamhuber added the enhancement New feature or request label Jul 31, 2024
@ligerzero-ai
Copy link

Hi Liam, is this implemented yet?

@liamhuber
Copy link
Member Author

Nope. It is still an idea I like though.

There is now functionality to for composites to keep running after a child fails, and only raise the error once all other calculation paths finish, so this should make implementation easier.

@ligerzero-ai
Copy link

ligerzero-ai commented Nov 27, 2024

So, you won't be mad if I hacked in universal try; except statements into nodes which I expect to fail occasionally?

I'll do it for now on the VASP nodes, we can remove in the future if necessary.

@liamhuber
Copy link
Member Author

I mean, I won't be happy but what you do inside your nodes is your business 😂

The nodes also have a "failed" output signal, so you might be able to use this to route to different data processing steps (i.e. real processing and placeholder "something went wrong" data) to make it less opaque

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants