Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pref for socket timeout #355

Closed
pyamsoft opened this issue Nov 8, 2024 · 0 comments
Closed

Pref for socket timeout #355

pyamsoft opened this issue Nov 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request next release This Feature will go out with the next release

Comments

@pyamsoft
Copy link
Owner

pyamsoft commented Nov 8, 2024

See related #349

To save memory and free up coroutines, we dropped the hard coded timeout to 10 seconds.

However, some websites do in fact take longer to read/write the socket, namely in 349 where the website takes almost 2 minutes.

Like the power balance, allow users to configure Socket timeout. Recommend power balance unlimited for fastest response and lowest connection latency.

3 sec - note that this uses the least memory, lowest latency, but may be TOO fast. Unlimited power balance recommended.
10 sec - default, balance between memory and connection allowance, compat with most well behaved websites
1 min - use more memory, higher latency, compatibility with many websites
5 min - lots of mem, lots of latency in some cases, most websites will work
Unlimited - yolo dolo I hope the website you are connecting to is well behaved

@pyamsoft pyamsoft added enhancement New feature or request next release This Feature will go out with the next release labels Nov 8, 2024
@pyamsoft pyamsoft self-assigned this Nov 8, 2024
@pyamsoft pyamsoft closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next release This Feature will go out with the next release
Projects
None yet
Development

No branches or pull requests

1 participant