Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astropy and pre-submission inquiry #280

Closed
pllim opened this issue Feb 14, 2024 · 9 comments
Closed

Astropy and pre-submission inquiry #280

pllim opened this issue Feb 14, 2024 · 9 comments

Comments

@pllim
Copy link
Contributor

pllim commented Feb 14, 2024

Hello! This is a follow-up of APE 22 that was accepted in astropy/astropy-APEs#87 . Recently our Community Manager, Beryl Kanali, has published a Astropy Community Survey Results. In the report, particularly in 6.1.3 Standards for Affiliated Packages, there is a desire for the following:

Clearer documentation (including tutorials) about how to convert an existing package to an Astropy Affiliated package (without assuming the person who wants to do this is already an Astropy developer).

I wonder if the pre-submission inquiry would be a good solution for this. If so, how can the existing pre-submission form be updated to this effect? Hope you can advise. Thanks!

cc @dhomeier @hamogu

Might be related:

@lwasser
Copy link
Member

lwasser commented Feb 24, 2024

hey @pllim 👋 this is our software submission issue list (where reviews take place). it sounds like we have something related to documentation to sort out but i wondered if you'd be ok if we move this issue to our peer review guide repository? which i think is the best place for a procedural discussion. are you ok with that?

@pllim
Copy link
Contributor Author

pllim commented Feb 24, 2024

Yes, sorry, please move it to appropriate repo as you see fit. Thanks!

@lwasser lwasser transferred this issue from pyOpenSci/software-submission Feb 27, 2024
@lwasser
Copy link
Member

lwasser commented Feb 27, 2024

hi there @pllim cc: @hamogu @dhomeier this is moving i think now. id love a bit more information

Clearer documentation (including tutorials) about how to convert an existing package to an Astropy Affiliated package (without assuming the person who wants to do this is already an Astropy developer).

Can you help me understand what you mean by how to convert an existing package to an astropy affiliated package? Does that mean the package has already been astropy affiliated / approved? or can you help me understand what an existing package means?

We can then go from there.

@pllim
Copy link
Contributor Author

pllim commented Feb 27, 2024

Can you help me understand what you mean by how to convert an existing package to an astropy affiliated package?

Let's say some astronomers wrote a package for their research. Now they think their package is mature and could be generally useful (or they just want something shiny for an upcoming paper, or whatever), and they think their package qualifies as something within the Astropy ecosystem, so they would now want to apply to be an Astropy Affiliated package. I hope this clarifies the issue?

@lwasser
Copy link
Member

lwasser commented Feb 27, 2024

ahhhh it does. absolutely. i think a presubmission is the way to go. we may not have a check box for that template - yet but we can create one. then we'd want one of the astropy editors to make the call on whether it's in scope for astropy. our EiC would make the scope call for pyOpenSci.

that seems very reasonable and would fit into our existing processes.

cc: @isabelizimm and @NickleDave for input just in case they have any given they've both served in this role now on our end.

@lwasser
Copy link
Member

lwasser commented Feb 27, 2024

we have this now in our presubmission template for pangeo. so let's just do the same for astropy pending everyone else's feedback of course.

@hamogu
Copy link

hamogu commented Feb 27, 2024 via email

@lwasser
Copy link
Member

lwasser commented Feb 27, 2024

Perfect. i will work on this and will get back to you when there is astropy support in our presubmission process. ✨

@lwasser
Copy link
Member

lwasser commented Apr 3, 2024

ok y'all - this has been implemented here via this check box in the pre-submission inquiry. i will close this but please reopen if you have questions / require followup!!

@lwasser lwasser closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants