Updating release procedure #480
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
CHANGELOG.md
Outdated
|
|
||
| ### Improvements | ||
|
|
||
| - Added secret support for all fields in DeploymentSettings [#419](https://github.com/pulumi/pulumi-pulumiservice/issues/419) |
There was a problem hiding this comment.
Heh, it seems like I'm just noticing this, but the CHANGELOG should link to the PRs that fix the issues instead of the issues themselves. Let's fix it for this one and going forward.
There was a problem hiding this comment.
Updated to have PR links instead, but now that I think of it, how can you link to a PR that doesn't exist until the change? 🤔
Like, I make an edit, add a line to CHANGELOG, but where do I link? I guess can predict the number based on latest, but yeah
There was a problem hiding this comment.
I usually do a new commit for the changelog once I open the PR and know what the number is
IaroslavTitov
force-pushed
the
iaro/release
branch
from
cce9c1e to
4ba38d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
Summary
Testing