Adds support for repository to be an output, Adding in test for #133 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
rshade
force-pushed
the
test-image-args
branch
from
c90a9ef to
f4e9d0d
Compare
rshade
changed the title
rshade
force-pushed
the
test-image-args
branch
from
2207ee9 to
25a9549
Compare
|
I pinned google-protobuf because of this issue: pulumi/pulumi#17421 |
rshade
force-pushed
the
test-image-args
branch
3 times, most recently
from
48c36db to
957ed33
Compare
rshade
force-pushed
the
test-image-args
branch
from
5e9351a to
e567a13
Compare
blampe
approved these changes
Dec 30, 2024
| @@ -0,0 +1,16 @@ | |||
| # EditorConfig helps maintain consistent coding styles across editors and IDEs | |||
| # More details at https://editorconfig.org | |||
There was a problem hiding this comment.
Interesting. Eventually I'd like ci-mgmt to ship some commit hooks to apply consistent linting and formatting for us.
There was a problem hiding this comment.
That would be great. I love editorconfig. It allows, it allows vscode to just know what to use automagically. We could ship it via ci-mgmt, like we do go-release.
There was a problem hiding this comment.
I added it because the default to .ts is 4spaces in my vscode and it kept refactoring files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in a test for #133, with image arguments. It also sets the chart version to match the image version.