Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DigitalOcean ReservedIp resource has a field urn that clashes with Pulumi urn #528

Closed
lbialy opened this issue Nov 5, 2023 · 1 comment
Closed

DigitalOcean ReservedIp resource has a field urn that clashes with Pulumi urn #528

lbialy opened this issue Nov 5, 2023 · 1 comment
Assignees
@mjeffryes
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@lbialy
Copy link
Contributor

lbialy commented Nov 5, 2023

What happened?

While generating digitalocean package for Pulumi-scala we have ran into an issue with ReservedIp resource. Codegen for Pulumi Scala (and scala compiler too) is stricter than existing codegens and it's an error for resources to have a field conflicting with reserved Pulumi field name. In this case it's urn field of ReservedIp that's conflicting. This is probably also causing #352. I have submitted a PR #515 to fix this.

Example

Not easy to do, but easy to check, see here https://www.pulumi.com/registry/packages/digitalocean/api-docs/reservedip/#urn_nodejs

Output of pulumi about

Codegen for besom 0.2.0-snapshot so no pulumi about

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@lbialy lbialy added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Nov 5, 2023
@lbialy lbialy mentioned this issue Nov 5, 2023
Closed
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Nov 6, 2023
@mjeffryes mjeffryes self-assigned this Sep 26, 2024
@mjeffryes mjeffryes added the resolution/fixed This issue was fixed label Sep 26, 2024
@mjeffryes
Copy link
Member

Fixed in #547

@mjeffryes mjeffryes mentioned this issue Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjeffryes mjeffryes

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjeffryes @mikhailshilkov @lbialy