Fix cert auth test #3871
Merged
Fix cert auth test #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3871 +/- ##
==========================================
- Coverage 57.11% 57.11% -0.01%
==========================================
Files 79 79
Lines 12423 12423
==========================================
- Hits 7096 7095 -1
- Misses 4800 4801 +1
Partials 527 527 ☔ View full report in Codecov by Sentry. |
thomas11
force-pushed
the
tkappler/test-fixes
branch
from
a201182 to
9629dca
Compare
thomas11
changed the title
danielrbradley
approved these changes
Jan 21, 2025
|
This PR has been shipped in release v2.84.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
TestAccKeyVaultTs_ClientCert. Another issue revealed that due to a misconfiguration, this test didn't use certificate auth as intended but fell through to CLI auth.