[v3] Detect resource path conflicts and disambiguate #3817
+364
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3817 +/- ##
=========================================
Coverage ? 56.74%
=========================================
Files ? 79
Lines ? 12351
Branches ? 0
=========================================
Hits ? 7009
Misses ? 4814
Partials ? 528 ☔ View full report in Codecov by Sentry. |
thomas11
force-pushed
the
tkappler/path-conflicts
branch
from
317863e to
284e727
Compare
thomas11
force-pushed
the
tkappler/path-conflicts
branch
from
284e727 to
a5fa911
Compare
thomas11
force-pushed
the
tkappler/path-conflicts
branch
from
a5fa911 to
ea458e3
Compare
thomas11
force-pushed
the
tkappler/path-conflicts
branch
from
ea458e3 to
d3af70c
Compare
thomas11
force-pushed
the
tkappler/path-conflicts
branch
from
656fb9b to
7a1874c
Compare
thomas11
commented
Jan 8, 2025
| canonPath := paths.NormalizePath(resource.Path) | ||
|
|
||
| typeName := resource.typeName | ||
| if g.majorVersion > 3 { |
|
Summary from conversation: add typed strings for |
thomas11
force-pushed
the
tkappler/path-conflicts
branch
from
7a1874c to
2e1b64a
Compare
thomas11
force-pushed
the
tkappler/path-conflicts
branch
from
5ca52d9 to
0a241ea
Compare
thomas11
force-pushed
the
tkappler/path-conflicts
branch
from
0a241ea to
16add24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3815 and contains its commits.
Resolves #2495
Resolves #2753
Previously, schema and metadata generation of this provider assumed that a type token like
azure-native:netapp:Pooluniquely identifies a resource. In the Azure spec, that's not always the case across API versions.For instance, as shown by #2753, resources such as
PrivateEndpointConnectioncan point to the /servers/ API in one API version but to the newer /flexibleServers/ API, which is a completely different product underneath, in another version.This PR does two things:
PrivateEndpointConnection, we rename the resource toSingleServerPrivateEndpointConnectionwhen it points to the /servers/ API.Any change to the generated schema is gated behind a "version >= 3" check to avoid breaking changes in v2.