Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate crd packages #51

Open
keithharvey opened this issue Jul 22, 2021 · 1 comment
Open

Duplicate crd packages #51

keithharvey opened this issue Jul 22, 2021 · 1 comment
Labels
area/codegen Affects quality or correctness of generated code impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@keithharvey
Copy link

keithharvey commented Jul 22, 2021 •
edited
Loading

Context

Hey, great work on crd2pulumi. One issue I just hit on trying to pulumi up after I imported my second crd2pulumi converted library was that both node packages had the default nodeName of "crd".

This resulted in an "incorrect semver" error because it tried to compare the version of the first library (which was an empty string by default) and the newly converted library (which also was an empty string) and node semver choked. Giving them both unique nodeName parameters cleared it up.

Possible solutions

  • Make at least 1 language target required. So users of crd2pulumi must specify nodejs and nodejsPath and nodeName.
  • attach a guid to the default "crd"
@keithharvey keithharvey added the kind/enhancement Improvements or new features label Jul 22, 2021
@leezen leezen added the impact/usability Something that impacts users' ability to use the product easily and intuitively label Jul 22, 2021
@mattolenik mattolenik added the area/codegen Affects quality or correctness of generated code label Jun 2, 2022
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/3431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/codegen Affects quality or correctness of generated code impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattolenik @keithharvey @leezen @cleverguy25