Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If field name contains a dash invalid Typescript is generated. #25

Closed
liamawhite opened this issue Feb 23, 2021 · 1 comment
Closed
Assignees
Labels
area/codegen Affects quality or correctness of generated code kind/bug Some behavior is incorrect or out of spec language/javascript resolution/duplicate This issue is a duplicate of another issue

Comments

@liamawhite
Copy link

Expected behavior

The cli to recognize that current-context should be renamed to currentContext

Current behavior

Invalid field names e.g. current-context:

...
        export interface SpinnakerAccountSpecKubernetesKubeconfig {
...
            current-context: string;
...

Steps to reproduce

Generate the following crd in typescript https://github.com/armory/spinnaker-operator/blob/master/deploy/crds/spinnaker.io_spinnakeraccounts_crd.yaml#L169

@infin8x infin8x added kind/bug Some behavior is incorrect or out of spec and removed bug labels Jul 10, 2021
@mattolenik mattolenik added language/javascript area/codegen Affects quality or correctness of generated code labels Jun 2, 2022
@rquitales
Copy link
Member

Closing in favor of #101 as there is more discussion in that issue.

@rquitales rquitales self-assigned this Sep 13, 2024
@rquitales rquitales added the resolution/duplicate This issue is a duplicate of another issue label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen Affects quality or correctness of generated code kind/bug Some behavior is incorrect or out of spec language/javascript resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

5 participants