Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot generate Traefik CRD's in TypeScript #21

Closed
Temikus opened this issue Jan 2, 2021 · 2 comments · Fixed by #143
Closed

Cannot generate Traefik CRD's in TypeScript #21

Temikus opened this issue Jan 2, 2021 · 2 comments · Fixed by #143
Assignees
Labels
area/codegen Affects quality or correctness of generated code kind/bug Some behavior is incorrect or out of spec language/javascript resolution/fixed This issue was fixed

Comments

@Temikus
Copy link

Temikus commented Jan 2, 2021

Here's the repro, lemme know if there's any additional info you need.

VERSION:

λ crd2pulumi -v
crd2pulumi version v1.0.5

REPRO:

λ git clone https://github.com/traefik/traefik-helm-chart
λ cd traefik-helm-chart/traefik/crds
λ crd2pulumi -n *
Successfully generated code.
λ tree crds
crds
└── nodejs
    ├── README.md
    ├── index.ts
    ├── meta
    │   └── v1.ts
    ├── package.json
    ├── provider.ts
    ├── tsconfig.json
    └── utilities.ts
λ cat crds/nodejs/index.ts
// *** WARNING: this file was generated by crd2pulumi. ***
// *** Do not edit by hand unless you're certain you know what you are doing! ***

// Export members:
export * from "./provider";
@joeduffy
Copy link
Member

joeduffy commented Jan 3, 2021

I believe this is because the Traefik CRDs don't yet have the v1-style schema, an OpenAPI style description of the CRD's properties (see traefik/traefik#5473). This is what crd2pulumi uses to generate strongly typed wrappers. It is unfortunate that the tool seems to just silently skip over CRDs without schemas. A warning at the very least would be extremely useful.

@mattolenik mattolenik added language/javascript area/codegen Affects quality or correctness of generated code labels Jun 2, 2022
@mnlumi mnlumi added the kind/bug Some behavior is incorrect or out of spec label Aug 1, 2023
@pulumi-bot pulumi-bot added resolution/fixed This issue was fixed labels Sep 13, 2024
@pulumi-bot
Copy link

This issue has been addressed in PR #143 and shipped in release v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen Affects quality or correctness of generated code kind/bug Some behavior is incorrect or out of spec language/javascript resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants