Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support pulumi.MapMapMapInput #142

Closed
swarupdonepudi opened this issue Sep 2, 2024 · 3 comments · Fixed by #143
Closed

support pulumi.MapMapMapInput #142

swarupdonepudi opened this issue Sep 2, 2024 · 3 comments · Fixed by #143
Assignees
@rquitales
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@swarupdonepudi
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Generated golang types for https://github.com/keycloak/keycloak-k8s-resources/tree/25.0.4/kubernetes crds contain pulumi.MapMapMapInput which is not found in standard pulumi types which results in go build error for the generated types.

go vet ./...
# github.com/plantoncloud/kubernetes-crd-pulumi-types/pkg/keycloak/k8s/v2alpha1
vet: pkg/keycloak/k8s/v2alpha1/pulumiTypes.go:11046:21: undefined: pulumi.MapMapMapInput

Affected area/feature

Unable to generate valid golang types for keycloak crds.
@swarupdonepudi swarupdonepudi added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Sep 2, 2024
@rquitales
Copy link
Member

Thanks for reporting this codegeneration issue. We're currently reworking our logic for code generation, and will be sure to validate that it also resolves this error.

@rquitales rquitales added kind/bug Some behavior is incorrect or out of spec and removed kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Sep 5, 2024
@swarupdonepudi
Copy link
Author

Awesome. Could you please let me know if there is any estimation on how long it might take? Helps with my planning.

@rquitales rquitales mentioned this issue Sep 12, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 13, 2024
@shamil shamil mentioned this issue Sep 16, 2024
Closed
@pulumi-bot
Copy link

This issue has been addressed in PR #143 and shipped in release v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rquitales rquitales

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revamp schemagen logic pulumi/crd2pulumi
3 participants
@swarupdonepudi @rquitales @pulumi-bot