Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure valid code is generated #116

Closed
guineveresaenger opened this issue Oct 3, 2023 · 1 comment
Closed

Add test to ensure valid code is generated #116

guineveresaenger opened this issue Oct 3, 2023 · 1 comment
Assignees
@rquitales
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@guineveresaenger
Copy link

A community member filed pulumi/pulumi-kubernetes#2580 as a result of changes in codegen to the pulumi-kubernetes SDK.

In this particular case, the issue was an internal-only package for PkgVersion() in the Go SDK, but we should ensure valid code is generated.
@mikhailshilkov mikhailshilkov added the kind/engineering Work that is not visible to an external user label Oct 4, 2023
@rquitales
Copy link
Member

Resolved in #143

@rquitales rquitales self-assigned this Sep 13, 2024
@rquitales rquitales added the resolution/fixed This issue was fixed label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rquitales rquitales

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikhailshilkov @guineveresaenger @rquitales