Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure type tokens use crd package name #110

Closed
AaronFriel opened this issue Apr 13, 2023 · 3 comments · Fixed by #143
Closed

Ensure type tokens use crd package name #110

AaronFriel opened this issue Apr 13, 2023 · 3 comments · Fixed by #143
Assignees
@rquitales
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@AaronFriel
Copy link

AaronFriel commented Apr 13, 2023 •
edited
Loading

The type tokens generated in crd2pulumi may use the kubernetes package in their names, causing unexpected codegen output. This is not an intended feature of codegen.

Type references in the schema generated by crd2pulumi should either be external references if they refer to valid Kubernetes types, or as in the case below, be generated into the types map of the schema using the package name of the crd package, not, e.g. kubernetes.

See:
@AaronFriel AaronFriel changed the title Ensure type tokens are generated with the package name. The type tokens generated in crd2pulumi may use the kubernetes package in their names, causing unexpected codegen output. This is not an intended feature of codegen. Type references in the schema generated by crd2pulumi should either be external references if they refer to valid Kubernetes types, or as in the case below, be generated into the types map of the schema using the package name of the crd package, not, e.g. kubernetes. Ensure type tokens use crd package name Apr 13, 2023
@justinvp
Copy link
Member

justinvp commented Apr 13, 2023 •
edited
Loading

Note that this would only work for types. The generated CRD resources would have to remain kubernetes in order for them to work correctly at runtime.

@mnlumi mnlumi added the kind/engineering Work that is not visible to an external user label Jul 21, 2023
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/3431

@rquitales rquitales mentioned this issue Sep 12, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 13, 2024
@pulumi-bot
Copy link

This issue has been addressed in PR #143 and shipped in release v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rquitales rquitales

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revamp schemagen logic pulumi/crd2pulumi
6 participants
@justinvp @AaronFriel @cleverguy25 @rquitales @pulumi-bot @mnlumi