From a15f538571c4a21a051b91355bfe029ac6fadb32 Mon Sep 17 00:00:00 2001 From: Robert-Anthony Lee-Faison <108823963+leefaisonr@users.noreply.github.com> Date: Thu, 29 Jun 2023 10:17:53 -0400 Subject: [PATCH] Fix the quoting for subguide importing (#98) add example link for puliiif production Co-authored-by: Bess Sadler Co-authored-by: Carolyn Cole Co-authored-by: Jane Sandberg --- app/services/sub_guide_loading_service.rb | 2 +- docs/image-processing.md | 2 ++ spec/fixtures/subguide_card_fixture.csv | 3 ++- spec/services/sub_guide_loading_service_spec.rb | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/app/services/sub_guide_loading_service.rb b/app/services/sub_guide_loading_service.rb index de33cf0b..6cc5ea6c 100644 --- a/app/services/sub_guide_loading_service.rb +++ b/app/services/sub_guide_loading_service.rb @@ -11,7 +11,7 @@ def initialize(csv_location: nil) end def import - sub_guide_card_data = CSV.parse(File.read(csv_location), headers: true) + sub_guide_card_data = CSV.parse(File.read(csv_location), headers: true, liberal_parsing: true) sub_guide_card_data.each do |entry| import_sub_guide_card(entry) end diff --git a/docs/image-processing.md b/docs/image-processing.md index 94883391..436be9a4 100644 --- a/docs/image-processing.md +++ b/docs/image-processing.md @@ -42,6 +42,8 @@ To verify that the images have uploaded correctly: https://puliiif-staging.princ Ex: https://puliiif-staging.princeton.edu/iiif/2/imagecat-disk1-0012-A1087-0000.0078/full/,500/0/default.jpg +This is an example link of an image in puliiif production: https://puliiif.princeton.edu/iiif/2/imagecat-disk1-0675-B1764-0000.0219/full/,500/0/default.jpg + ## Helpful tmux tips If we need to delete a tmux session, we can run the following command: diff --git a/spec/fixtures/subguide_card_fixture.csv b/spec/fixtures/subguide_card_fixture.csv index 99859d14..b9656dd2 100644 --- a/spec/fixtures/subguide_card_fixture.csv +++ b/spec/fixtures/subguide_card_fixture.csv @@ -3,4 +3,5 @@ ID,heading,sortid,parentid,path,heading,sortid,parentid,path 2,Afdeling natuurkunde,50350.5,50345.5,9/0091/A3067,Afdeling natuurkunde,50350.5,50345.5,9/0091/A3067 3,Afdeling voor ...,50351.5,50345.5,9/0091/A3038,Afdeling voor ...,50351.5,50345.5,9/0091/A3038 4,(Without subdivision),50352.5,540.5,sub,(Without subdivision),50352.5,540.5,sub -5,(As author),50353.5,50352.5,sub,(As author),50353.5,50352.5,sub \ No newline at end of file +5,(As author),50353.5,50352.5,sub,(As author),50353.5,50352.5,sub +57,Nauchnyi sovet "Istoriia istoricheskoi nauki " ... 8/0097/A3100,50405.5,50358.5,8/0097/A3100,Nauchnyi sovet "Istoriia istoricheskoi nauki " ... 8/0097/A3100,50405.5,50358.5,8/0097/A3100 \ No newline at end of file diff --git a/spec/services/sub_guide_loading_service_spec.rb b/spec/services/sub_guide_loading_service_spec.rb index 8085fe11..e6b661d4 100644 --- a/spec/services/sub_guide_loading_service_spec.rb +++ b/spec/services/sub_guide_loading_service_spec.rb @@ -15,6 +15,6 @@ it 'imports all data from the CSV file' do expect(SubGuideCard.count).to eq 0 sgls.import - expect(SubGuideCard.count).to eq 5 + expect(SubGuideCard.count).to eq 6 end end