Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate queries to Ex Libris' Summon to 1000 characters #322

Open
maxkadel opened this issue Nov 12, 2024 · 0 comments
Open

Truncate queries to Ex Libris' Summon to 1000 characters #322

maxkadel opened this issue Nov 12, 2024 · 0 comments
Labels
bug 🐛 Something isn't working

Comments

@maxkadel
Copy link
Collaborator

maxkadel commented Nov 12, 2024

Expected behavior

When a user puts in a very long query, it is still queried against the Summon article service

Actual behavior

Very long queries only get an error from Summon and are not searched.

example very long url

produces

{
  "error": {
    "problem":"UPSTREAM_ERROR",
    "message":"Query too long. Max Length: 1000 Query Length: 1022"
  }
}

Steps to replicate

  • Put a string over 1000 characters in an allsearch-api search (start with https://allsearch-api.princeton.edu/search/article?query= then put over 1K characters after)

Impact of this bug

Very long queries are not searched against the articles at all

Honeybadger link

https://app.honeybadger.io/projects/114176/faults/109358488/01JCCN7VZEHK034N7HYBSK8VJ9?page=0

Implementation notes, if any

@maxkadel maxkadel added the bug 🐛 Something isn't working label Nov 12, 2024
@maxkadel maxkadel changed the title Truncate queries to summon to 1000 characters Truncate queries to Ex Libris' Summon to 1000 characters Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant