Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant initialiser #22

Open
marksteward opened this issue Mar 21, 2016 · 1 comment
Open

Fix constant initialiser #22

marksteward opened this issue Mar 21, 2016 · 1 comment

Comments

@marksteward
Copy link
Contributor

This should be data=None with a check that initialises it:

https://github.com/pubstandards/pubstandards-london/blob/master/ps_data.py#L22

(it doesn't currently matter)
@jaylett
Copy link
Contributor

jaylett commented Mar 21, 2016

Top re-entrancy :-)

(The reason it doesn't currently matter is so subtle that it makes me want to rewrite the PSEvent constructor to make things…more clear.)

marksteward added a commit that referenced this issue Mar 27, 2016
@marksteward
Fix override attribute and default description
44c159a 
Rework constructor of PSEvents so that it always take a date, and
the override attribute is accurate. This allows us to compare two
PSEvents for equality and use .override in templates.

Fixes #8, #15 and #22
@marksteward marksteward mentioned this issue Mar 27, 2016
Open
marksteward added a commit that referenced this issue Mar 27, 2016
@marksteward
Fix override attribute and default description
083b9b4 
Rework constructor of PSEvents so that it always take a date, and
the override attribute is accurate. This allows us to compare two
PSEvents for equality and use .override in templates.

Fixes #8, #15 and #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaylett @marksteward