Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "in no minutes" to "imminent" or something #10

Open
marksteward opened this issue Feb 12, 2015 · 3 comments
Open

Change "in no minutes" to "imminent" or something #10

marksteward opened this issue Feb 12, 2015 · 3 comments
Labels

Comments

@marksteward
Copy link
Contributor

"In no minutes" is a bit odd unless you know what it means. Alternatively, just switch to "Happening right now" a minute early.

@marksteward
Copy link
Contributor Author

Also add "happening now" to the event-specific page. http://london.pubstandards.com/event/pub-standards-cxi. It currently says "Will be held", which is weird when the event's started or nearly finished.

@Jonty
Copy link
Member

Jonty commented Feb 12, 2015

This code is a direct port from the old site, it will also say things like "In one day, no hours, and no minutes" which is really weird.

Happening now should certainly link to the page. In fact, the timestamp should generally link to the page I suspect.

@marksteward
Copy link
Contributor Author

Oh, I meant add a "happening now" state - at the moment, it's either future or past. Linking to the next PS sounds like an idea, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants