-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hash prototype definitions into json file #29
Comments
That sounds good. I can look at it a bit more in a few days. Do you want me to do this, or did you just want some feedback? Also, it's possible to have |
Well at first I wanted some feedback since the regular expressions will be harder to maintain because we can't use raw strings. If you want you can start working on this (Pull Requests are welcome 😉). The idea of having an option to let users specify the path to the JSON file sounds good! |
You know.... I have no idea how I did that. Here's a completely different solution: https://gist.github.com/bburky/c7e1f955b10570c38f16. That has the new JSON for the current list of prototypes and the Python code I used to generate it. Do you want to the work to adapt the current HashID code to load the prototypes from JSON, or should I do it? I haven't kept up with HashID recently. It looks like it changed a little since I last looked at it. |
I never really dealt with JSON or installing data files using |
@bburky Since the list of regular expressions is growing very fast and hashID is now installed via a
setup.py
(as you suggested earlier), maybe we can reconsider f36444c and move the prototype definitions into a json file.What do you think?
The text was updated successfully, but these errors were encountered: