Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Issue and PR templates #110

Closed
3 tasks
nateinaction opened this issue Jan 25, 2025 · 4 comments · Fixed by #118
Closed
3 tasks

Add GitHub Issue and PR templates #110

nateinaction opened this issue Jan 25, 2025 · 4 comments · Fixed by #118
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@nateinaction
Copy link
Member

Story

As a PROVES Kit code reviewer
I want PR and Issue templates that describe requirements for those interactions
So that I more easily review those documents

Acceptance Criteria

  • Issues templates
    • Bug report template
      • Summary
      • Reproduction steps
    • New feature template
      • Story
        • As a
        • I want
        • So that
      • Acceptance Criteria
      • Technical Details
  • PR template
    • Summary
    • How was this tested
      • Added new unit tests
      • Ran code on the hardware (screenshots are helpful)
      • Other (Please describe)

Technical Details

@JamesDCowley JamesDCowley self-assigned this Jan 26, 2025
@Mikefly123 Mikefly123 added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 26, 2025
@JamesDCowley JamesDCowley linked a pull request Jan 29, 2025 that will close this issue
1 task
@nateinaction
Copy link
Member Author

Reopening.

Hey @JamesDCowley when you get a chance can you take a look at the PR template again? It looks like it's not showing up for me:

Image

@nateinaction nateinaction reopened this Jan 29, 2025
@JamesDCowley
Copy link
Contributor

JamesDCowley commented Jan 30, 2025

Created a pull request (#123) for this. Changing the name to be lowercase may work.

@JamesDCowley
Copy link
Contributor

Last PR didn't seem to work, going to try and move the PR template file out of its own directory and put it in /.github

@JamesDCowley
Copy link
Contributor

That last PR worked 👍

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants