Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of filter button to "Apply Filters" #2524

Closed
lukefretwell opened this issue Mar 19, 2024 · 3 comments
Closed

Change name of filter button to "Apply Filters" #2524

lukefretwell opened this issue Mar 19, 2024 · 3 comments

Comments

@lukefretwell
Copy link
Contributor

lukefretwell commented Mar 19, 2024

Builds

Source

https://airtable.com/appRFUc45sF4yWFut/tbl51inE74gEWlB0x/viwG9G4vAjsjQEh4g/recuzE962cNqhepj3?blocks=hide

Describe the bug

A clear and concise description of what the bug is.

When the screen reader user heard "filter" he assumed it was a button to open a modal with more filters. He bypassed it and expected that the filter he had checked would have been applied already.

Recommendation

Recommend changing the name of the button to "Apply Filters" to make it clear that it should be selected in order for the selection to be aplied.

Screenshots

If applicable, add screenshots to help explain your problem.

filter

@lukefretwell lukefretwell added this to the Pacific ADA feedback milestone Mar 19, 2024
@curtismchale curtismchale self-assigned this Apr 4, 2024
curtismchale added a commit to proudcity/wp-proud-core that referenced this issue Apr 4, 2024
@curtismchale
Copy link
Contributor

@kevindherman @lukefretwell this is deployed to beta. You can see the new button text here: https://beta.proudcity.com/events/

@kevindherman
Copy link

@curtismchale @lukefretwell looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants