Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initials and avatar Fields missing on ResourceDto #28

Open
gcmestre opened this issue Oct 9, 2024 · 2 comments
Open

Initials and avatar Fields missing on ResourceDto #28

gcmestre opened this issue Oct 9, 2024 · 2 comments

Comments

@gcmestre
Copy link
Contributor

gcmestre commented Oct 9, 2024

Hey,

I encountered the error described above while fetching data.
Those fields were missing.

I created a pull request adding those fields to the ResourceDto.

I feel like every week there is an issue or an error thrown using the sdk.
Would be great if something could be done on the API side or the sdk to try to be more stable.
Maybe a more synced deployment of changes on the API and changes on the SDK, is just a suggestion.

Thank you

@tspence
Copy link
Contributor

tspence commented Oct 18, 2024

Thanks for this report! I believe you're talking about the issue where an old version of the SDK was using **/kwargs instead of dacite to parse JSON, which meant that it would fail if it received JSON text that included a new field not known when the API was built. That issue was fixed with #26 and should not be recurring.

Can you please confirm a few things for me?

  1. What version of the SDK are you using?
  2. What API call did you make?

As part of the problem reports for this issue I added tests to verify that this bug was completely fixed.

Here's a screenshot from my latest test which demonstrates that SDK version 119.0.4645 does not generate an error when fetching resources, even though those two fields are not present in that version of the SDK:

image

@tspence
Copy link
Contributor

tspence commented Oct 24, 2024

Update: We have released version 120 of the SDK which includes the Initials and Avatar fields on ResourceDto.

https://pypi.org/project/ProjectManagerSdk/

To update, run pip install --upgrade ProjectManagerSdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants