-
Notifications
You must be signed in to change notification settings - Fork 16
Implement the --cli-version and --path options for install-cli #326
Comments
@hferentschik |
I've seen that. But it does not mean that it works, right? When I tried to use the option, all I kept getting was the help message that I used the command wrong. Note, this help message does not even list the
Well, this might work on the
This test does not mean anything. My guess is that it returns 126, because it thinks it is an invalid option. This test needs to verify the exit code AND something else, for example that the error message is "invalid version for docker". Then I would believe the test. In fact I removed the test for now. These tests are dangerous, because they give you a feeling of misguided safety. The assertion must be specific enough to just fail/pass the condition I am testing.
+1. If you can do that and it works without any further code changes I take everything back. |
@budhrg what's the state here? Do this options exist or not? |
@hferentschik Documentation is remaining here. Will work with @Preeticp |
What's about integration tests. Last time I checked there were none. |
Merged via pull request #414 |
These options are not properly implemented yet. The help does not mention them, but they are mentioned in the README (going to remove it together with the Cucumber test which does not seem to do anything).
The text was updated successfully, but these errors were encountered: