-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JasperReports 7 compatibility #92
Comments
Hi, is there any progress or ETA on this issue ? Thanks. |
@Postremus Shouldn´t you be able to check the second box by definition? "Implement compatibility with JR 7" |
Comments on the "optional" items listed here: renaming: I think it would make sense to follow the naming convention -- however, it will cause the artifact name to change -- no doubt causing confusion for users -- however, since you are bumping the major version to 4.0.0, it would be the right time to do it dropping Maven 3.5.2 support: Many of the plugins require Maven 3.6.3 as a base -- moving the minimum to 3.9 might be a bit drastic unless you have a specific reason to do so -- I would suggest keeping at least 3.6.3 as a base minimum at least until Maven 4.0 is in wide use BTW, any way anyone can help with "implement compatibility with JR 7" ? Do you have "more details" on what's needed to be done? |
@rturner-edjuster If you look at the title "JasperReports 7 compatibility" I think that is all this PR does to be honest. |
Oh, my bad. I thought this was an PR ... sorry for the mess |
i create a PR for this issue |
I was doing the same. So I can stop working on that. Thx! |
We´ll test the PR next Monday with our production reports. I´ll get back here. |
@rturner-edjuster @Postremus with respect to the optional renaming. If you do this, please consider providing the relocation information in the maven pom. https://maven.apache.org/guides/mini/guide-relocation.html That way in maven central everyone can see, that the artefact was moved and where it moved to. It´s a bit tricky, since you have to publish a pom under the old group/arty-id with that relocation information. And 3.9 as a requirement is really quite harsh. |
Currently, I haven't found any issues related to this migration in the non-production environment. We are planning a load test in two weeks under production conditions. I will share the results here. |
That would be up to @Postremus -- I was just commenting to provide feedback from a user. However, I agree with the suggestion of making it easier to map the transition. |
My local testing of @stoufix 's PR #102 is successful. Seems to work as expected. |
@Postremus When are you planning und building a release for this? |
@RainerGanss I want to do some more sanity checks. Most likely I will build the release early next morning. |
@RainerGanss done |
JR 7 has just been released. https://repo1.maven.org/maven2/net/sf/jasperreports/jasperreports/7.0.0/
https://github.com/TIBCOSoftware/jasperreports/tree/release-7.0.0?tab=readme-ov-file#jasperreports-library-700-change-log
We should make sure this plugin is compatible with the newest version.
At least following tasks need to be done, in addition to some nice to haves:
-- Not going to drop maven 3.5.2 for now, since building reports with maven 4 seems to work fine.
The text was updated successfully, but these errors were encountered: