Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple build warnings #104

Closed
Postremus opened this issue Sep 9, 2024 · 2 comments
Closed

Multiple build warnings #104

Postremus opened this issue Sep 9, 2024 · 2 comments

Comments

@Postremus
Copy link
Contributor

From #102

If anyone is going to make additional changes to the PR, and if you want to eliminate some warnings during the build, you can also make the following changes:

  • pom.xml -> maven-failsafe-plugin -> renamed the systemProperties element to systemPropertyVariables (I get a deprecation warning on this -- however, if the maven-failsafe-plugin version isn't controlled by the project, could be host environment dependent)
  • change the classes JasperMojoConfiguration and JasperReportCompiler to be "package protected" instead of "public" (eliminates Javadoc warnings as these classes do not need to be public as far as I can tell).
@Postremus Postremus mentioned this issue Sep 9, 2024
Merged
@rturner-edjuster
Copy link
Contributor

@Postremus I'll create a PR for this (unless you are already doing so)

@Postremus
Copy link
Contributor Author

@rturner-edjuster Please do.

rturner-edjuster added a commit to rturner-edjuster/Jasper-report-maven-plugin that referenced this issue Sep 9, 2024
@rturner-edjuster
Fix pro-crafting#104: Eliminate some build warnings and fixed some typos
0e4ef8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Postremus @rturner-edjuster