Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on reneging stream active mark may need update. #1821

Closed
huitema opened this issue Jan 19, 2025 · 1 comment
Closed

Documentation on reneging stream active mark may need update. #1821

huitema opened this issue Jan 19, 2025 · 1 comment

Comments

@huitema
Copy link
Collaborator

huitema commented Jan 19, 2025

Reneging happens when an application marks a stream active, but cannot send data when receiving the "prepare to send" callback. A frequent case is when the proposed buffer is too small, and the application wants to wait for a larger buffer. The documentation in "send_receive_data.md" says that the application can do one of two things:

  • either call picoquic_provide_stream_data_buffer while requesting 0 bytes buffer and setting the `still_active' flag,
    /* Not sending here! */
    (void)picoquic_provide_stream_data_buffer(context, 0, 0, 1);
  • or call picoquic_mark_active_stream from within the call back, which according to the documentation is equivalent.

Except it does not actually seem equivalent, according to
this discussion. Trying the "mark active" approach appears to cause the application to stall.

We need to either update the documentation or fix the code to ensure that the "mark active" approach also works.

@huitema
Copy link
Collaborator Author

huitema commented Jan 23, 2025

Addressed in PR #1822

@huitema huitema closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant