Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Publisher app to allow ad url to be set in initializeFromStaticData #23

Open
c4mb0t opened this issue Dec 19, 2024 · 0 comments

Comments

@c4mb0t
Copy link
Contributor

c4mb0t commented Dec 19, 2024

When this change to PrivacySandboxViewModel.kt was made in the Publisher app, it resulted breaking the rendering of the winning ad during the ad selection flow.

Initial investigation shows that this happens because initializeFromStaticData is called after the call to retrieveAd() in init, which results in the winning ad url being overwritten with an empty string.

We should try to figure out why this happens, and what is the best way to refactor the app so that the logic flow is more intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant