Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter substitution is a bit unconventional #23

Closed
johannhof opened this issue Mar 19, 2024 · 0 comments · Fixed by #25
Closed

Getter substitution is a bit unconventional #23

johannhof opened this issue Mar 19, 2024 · 0 comments · Fixed by #25
Assignees

Comments

@johannhof
Copy link
Member

Our getter steps should probably use the form described in https://webidl.spec.whatwg.org/#getter-steps, I.e. start with the right words and use this instead of explicitly declaring handle and types.

Further, steps like Return the invocation of sessionStorage. seem incorrect, there's probably a better way of calling those getters on a different object, maybe just by copy-pasting their steps as some of the caching logic would need to be different anyway, see #19.

@arichiv arichiv self-assigned this Mar 19, 2024
@arichiv arichiv reopened this Mar 21, 2024
arichiv added a commit that referenced this issue Mar 21, 2024
Let's just say we `return the result of running x`. That seems closer to convention.

closes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants