Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong assumption that session requests requesting specific attribute value lead to a unique match #369

Open
ivard opened this issue Dec 14, 2023 · 1 comment

Comments

@ivard
Copy link
Member

ivard commented Dec 14, 2023

Given the following session:

{
"@context": "https://irma.app/ld/request/disclosure/v2",
"disclose": [
  [
    [ { "type": "irma-demo.sidn-pbdf.email.domain", "value": "test.nl" }]
  ]
]
}

If you already have [email protected] stored in your irmaclient, then there should be two options:

  • Select the existing [email protected]
  • Add a new credential (for another test.nl email address)

Now only the first option is showed.

@DibranMulder
Copy link

DibranMulder commented Jan 30, 2025

I validated this issue with the following test scenario:

irma session --server https://is.staging.yivi.app --authmethod token --key <redacted> --request '{ "@context": "https://irma.app/ld/request/disclosure/v2", "disclose": [[[ { "type": "irma-demo.sidn-pbdf.email.email" }, { "type": "irma-demo.sidn-pbdf.email.domain", "value": "caesar.nl" }]]]}'

In this case the irmaclient matches on my [email protected] credential that indeed has the caesar.nl domain but the other property email is left open, the user should be able to Add a new credential. I tracked the code down to the following lines, but it still needs further investigation.

func (ar *AttributeRequest) Satisfy(attr AttributeTypeIdentifier, val *string) bool {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants