Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inquirer): update codebase from inquirer to @inquirer/prompts #69

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

jharrell
Copy link
Member

@jharrell jharrell commented Oct 31, 2024

Resolves DA-1566

@jharrell jharrell self-assigned this Oct 31, 2024
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, but I left some questions in Slack that should be clarified before approving the PR.

@nikolasburk nikolasburk self-requested a review November 1, 2024 15:38
nikolasburk
nikolasburk previously approved these changes Nov 1, 2024
@mhessdev
Copy link
Contributor

mhessdev commented Nov 2, 2024

Screenshot 2024-11-02 at 10 22 47 AM

Could we change the descriptions to look different than selected text? It doesn't stand out that its the description.

@mhessdev
Copy link
Contributor

mhessdev commented Nov 2, 2024

Could we add a description to "Explore other examples"

@mhessdev
Copy link
Contributor

mhessdev commented Nov 2, 2024

Is there anyway to change this? I selected the prisma starter project but it says its downloading the databases/prisma-postgres not a huge issue but may make people thing what is being downloaded is incorrect
Screenshot 2024-11-02 at 10 24 23 AM

@mhessdev
Copy link
Contributor

mhessdev commented Nov 2, 2024

Screenshot 2024-11-02 at 10 27 01 AM

once its done installing the cli hangs, you have to do cmd+c to get out of it, can we get past that? Maybe even default into cd'ing into the new folder?

Copy link
Contributor

@mhessdev mhessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments on the main thread, woops. Take the ones that don't have to do with this PR and make issues out of them. Fix the others.

@jharrell
Copy link
Member Author

jharrell commented Nov 2, 2024

@mhessdev thanks for the feedback. I added a description for the "other examples" option and added a check to show "Prisma Starter" if you're downloading that repo.

@jharrell jharrell merged commit 89dc440 into main Nov 4, 2024
2 checks passed
@jharrell jharrell deleted the update-inquirer branch November 4, 2024 14:03
Copy link

github-actions bot commented Nov 4, 2024

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants