Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aws-graviton): update engine files assertion to include "deno" #5308

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Aug 5, 2024

This PR fixes the following - currently failing - ecosystem test:

  • test / platforms (aws-graviton, library, ubuntu-20.04)

Context: Slack.

@jkomyno jkomyno self-assigned this Aug 5, 2024
@jkomyno jkomyno requested a review from a team as a code owner August 5, 2024 09:19
@jkomyno jkomyno requested review from aqrln and millsp and removed request for a team August 5, 2024 09:19
@jkomyno jkomyno modified the milestones: 5.17.0, 5.18.0 Aug 5, 2024
@SevInf
Copy link
Contributor

SevInf commented Aug 5, 2024

Seems like binary engine also needs updating?

@jkomyno
Copy link
Contributor Author

jkomyno commented Aug 5, 2024

test(aws-graviton): update engine files assertion to include "deno"

Thank you, that's correct. Please see my latest commit.

@jkomyno jkomyno merged commit 4e09869 into dev Aug 5, 2024
37 checks passed
@jkomyno jkomyno deleted the fix/aws-graviton-engine-files-assertion branch August 5, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants