New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing coverage in rcon #9

Open

skibz opened this issue Aug 24, 2015 · 0 comments

Contributor

skibz commented Aug 24, 2015

see coveralls report for missed branches.

we need some kind of a mock/fake rcon server to run during tests to determine the following:

emission of the connected event
authentication packet being written after connected event
invocation of the queued callbacks in this.responseCallbacks
writing of queued commands in this.commands
clearing of queued commands in this.commands
SERVERDATA_RESPONSE_VALUE branch execution
SERVERDATA_AUTH_RESPONSE branch execution
error branch execution
auto-connect behaviour
immediate command writing if already authenticated

if we can cover all of these behaviours in tests, we'll have 100 (or close to) percent coverage. 🎉

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment