Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] Enhancements for the UX #21062

Open
12 of 16 tasks
yhwang opened this issue Oct 6, 2023 · 10 comments
Open
12 of 16 tasks

[tracking] Enhancements for the UX #21062

yhwang opened this issue Oct 6, 2023 · 10 comments
Assignees

Comments

@yhwang
Copy link
Member

yhwang commented Oct 6, 2023

When working on the UX changes, I observed some nice-to-have enhancements to the UX. I'd like to use this issue to list and track those possible enhancements:

Expected Behavior or Use Case

It would be good to have separate PRs to address each item listed above.

Presto Component, Service, or Connector

UX

Possible Implementation

Example Screenshots (if appropriate):

Context

@yhwang yhwang self-assigned this Oct 6, 2023
@yhwang
Copy link
Member Author

yhwang commented Oct 6, 2023

Feel free to add more items in the comments if you see fit and grab any item you'd like to work on. Let me assign this to myself and I will try to tackle them one by one.

Please also share your comments about the items I listed. Then I can prioritize them or even remove them if unnecessary.

@jaystarshot
Copy link
Member

Will session properties also work with #21576?

@yhwang
Copy link
Member Author

yhwang commented Jan 5, 2024

@jaystarshot good question also suggestion. Currently, session properties are not supported. This could be done in either the SQL Client component or presto-js-client. It's a good feature. Let me add it to the list.

@mbasmanova
Copy link
Contributor

I'd like to add a small change to Query Details page to allow hiding query text. Often queries are very long and it is difficult to get to the stages section of the pages (although my workaround is to just search for 'stages' in the browser).

@yhwang I wonder if you could maybe write some docs to explain what frameworks are used to put together the UI and how it works in general.

CC: @steveburnett

@yingsu00
Copy link
Contributor

@yhwang Would it be possible to add the table name to the scan operator in the live plan view?

@yhwang
Copy link
Member Author

yhwang commented Mar 25, 2024

@yingsu00 I tried to run some queries to check the live plan view. I saw the ScanFilter like this:
image

I saw the connectorHandle='customer.sf1.0' and it should indicate the table. Could you elaborate more about where you want to add the table name?

@VidhuDashora
Copy link

VidhuDashora commented May 7, 2024

Hi guys, sorry disregard the previous comment I had to remove it because it was the wrong account. Anyways, my name is Vidhu Dashora and I've started working on number 12,

12. The [suggestion](https://react.dev/reference/react/PureComponent#migrating-from-a-purecomponent-class-component-to-a-function) from React.js is to use function components. Refactor class components into function components.

cc: @yhwang

@tejkart
Copy link

tejkart commented May 8, 2024

Hi guys, my name is Tejas Karuturi and I will be working on task 13.

13. Enforce flow checker to all UI components.

cc: @yhwang

@yhwang
Copy link
Member Author

yhwang commented Feb 10, 2025

use this to track several style issues from the dependency upgrade PR:

@ethanyzhang
Copy link
Contributor

@unidevel can you work on the above 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants