Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --depth as a configurable option on sdmerge #26

Open
alissapajer opened this issue May 22, 2017 · 3 comments
Open

add --depth as a configurable option on sdmerge #26

alissapajer opened this issue May 22, 2017 · 3 comments
Assignees

Comments

@alissapajer
Copy link
Contributor

what it says

@sellout
Copy link
Contributor

sellout commented May 31, 2017

I would prefer if we could calculate the necessary depth automatically.

But in the mean time, only using --depth when it’s explicitly provided by the sdmerge user sounds reasonable.

@djspiewak
Copy link
Contributor

@sellout There's a chicken-or-egg problem here. It's trivial to infer --depth… once we have the commits. We can't infer --depth until we have the commits, by which point it's too late.

The only solution I can think of would be to iteratively clone things. Start with a low depth, and see if it contains the base hash. If it doesn't, grab the next n * 2 commits. Repeat until we find the base hash.

@sellout
Copy link
Contributor

sellout commented May 31, 2017

Well, we could use --shallow-since=<date of base hash>, but I was hoping there was some way to use the base hash directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants