Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic adjustment of compiler flags based on compiler/version #79

Open
MakisH opened this issue Feb 8, 2022 · 2 comments
Open

Automatic adjustment of compiler flags based on compiler/version #79

MakisH opened this issue Feb 8, 2022 · 2 comments
Assignees

Comments

@MakisH
Copy link
Member

MakisH commented Feb 8, 2022

We currently have the quick-and-dirty solution for GCC 10 or newer:

FFLAGS = -Wall -O3 -fopenmp $(INCLUDES)
# Note for GCC 10 or newer: add -fallow-argument-mismatch in the above flags

With Ubuntu 22.04 LTS, this will become a more pressing issue, as people will stumble upon it more often without reading the documentation.

We could easily make a condition in the Makefile to check if this is GCC and if it is >=10. Not necessarily now, just documenting the need. We have more pressing issues.

Maybe there is already some fix in the vanilla CalculiX Makefile?

@boris-martin
Copy link
Collaborator

Can't we just enable the flag in all cases, to be safe ?

@MakisH
Copy link
Member Author

MakisH commented Feb 8, 2022

No, because older compilers will complain that they don't know the flag. Already fell into this trap before. 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants