Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support filtering BidRequest to DSP based on adapter specific Geo country whitelist #3898

Closed
josepowera opened this issue Sep 2, 2024 · 2 comments

Comments

@josepowera
Copy link

With #3887 bidrequest from PBS will always have country (if enabled).

Idea: Adapters could have configuration string with whitelisted geo countrys.

Why: smaller DSPs are mostly country specific and when PBS does the filtering on single attribute, that would cut bandwidth significantly (from PBS to DSP).

If this is done on bidrequest before specific bid adapter it would be way more generic and would cut boilerplate code significantly (I'm sure nobody in interested in 100 adapters having same code).

If no adapter specific geo country is specified, it should pass all to DSPs (same as currently).

@josepowera josepowera changed the title Specify Bid Adapter allowed Geo country whitelist Support filtering BidRequest to DSP based on adapter specific Geo country whitelist Sep 3, 2024
@josepowera josepowera changed the title Support filtering BidRequest to DSP based on adapter specific Geo country whitelist Feature request: Support filtering BidRequest to DSP based on adapter specific Geo country whitelist Sep 5, 2024
@bretg
Copy link
Contributor

bretg commented Sep 5, 2024

@josepowera - assuming that by "DSP" you mean "bidder", this is covered in #2541

It has been argued the draft requirements for that module is much larger and more complicated than strictly necessary -- it covers many more use cases than just not sending requests to bidders based on the user's country. I would counter-argue that anyone wanting to build this feature could build just the pieces they're interested in and leave the rest of later phases.

Would also like to note that the workaround we've been suggesting is that Prebid-Server host companies and enable and disable bidders for each of their datacenters. For instance, in our cluster, we've only enabled lunamedia in our US datacenters because they asked us to their YAML file declared their 'geoscope' as US.

@bretg
Copy link
Contributor

bretg commented Sep 6, 2024

@josepowera - I'm going to assume that #2541 covers your request here. Please re-open with details if there's something in your request not covered there. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants