From 40801cc05788eddddc299e47afb7d2afbfc8cb32 Mon Sep 17 00:00:00 2001
From: Denis Sotskov <deniss@onlinemediasolutions.com>
Date: Sun, 2 Feb 2025 12:10:01 +0200
Subject: [PATCH] oms: added tests for invalid params, changed json marshal
 package, changed uri builder

---
 adapters/oms/oms.go         | 5 +++--
 adapters/oms/params_test.go | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/adapters/oms/oms.go b/adapters/oms/oms.go
index 8a4a4d5f010..c985abe4dc5 100644
--- a/adapters/oms/oms.go
+++ b/adapters/oms/oms.go
@@ -45,7 +45,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapte
 	var publisherID string
 	if len(request.Imp[0].Ext) > 0 {
 		ext := pbsExt{}
-		err = json.Unmarshal(request.Imp[0].Ext, &ext)
+		err = jsonutil.Unmarshal(request.Imp[0].Ext, &ext)
 		if err != nil {
 			return nil, []error{err}
 		}
@@ -58,7 +58,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapte
 
 	requestData := &adapters.RequestData{
 		Method: "POST",
-		Uri:    a.endpoint + fmt.Sprintf("?publisherId=%v", publisherID),
+		Uri:    fmt.Sprintf("%s?publisherId=%v", a.endpoint, publisherID),
 		Body:   requestJSON,
 		ImpIDs: openrtb_ext.GetImpIDs(request.Imp),
 	}
@@ -94,6 +94,7 @@ func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.R
 	if len(response.Cur) == 0 {
 		bidResponse.Currency = response.Cur
 	}
+
 	for _, seatBid := range response.SeatBid {
 		for i := range seatBid.Bid {
 			bidType := getBidType(seatBid.Bid[i].MType)
diff --git a/adapters/oms/params_test.go b/adapters/oms/params_test.go
index 32d17ddbdb7..4b2c0b67f5f 100644
--- a/adapters/oms/params_test.go
+++ b/adapters/oms/params_test.go
@@ -57,4 +57,5 @@ var invalidParams = []string{
 	`{}`,
 	`{"pid": "0"}`,
 	`{"publisherId": 9999}`,
+	`{"publisherId": "99999"}`,
 }