Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labelAll ignores value #11911

Closed
hmodes-qm opened this issue Jul 2, 2024 · 2 comments · Fixed by #11920
Closed

labelAll ignores value #11911

hmodes-qm opened this issue Jul 2, 2024 · 2 comments · Fixed by #11920

Comments

@hmodes-qm
Copy link

Type of issue

potential bug

Description

We're setting a label to include/exclude bidders from certain page types. The label is 'sod_true' or 'sod_false'. Bidders (i.e. seedtag) should only be called if the label's value is set to 'sod_true'. Here's the bidder config:

    		bidder: 'seedtag',
                labelAll: ['sod_true'],
    		params: {
          		publisherId: 'xxx',
          		adUnitId: 'yyy',
          		placement: 'inScreen',   
                },

I can see in Prebid's debugging mode that the label is set to 'sod_false'
image (3)
However I can also see that seedtag is beeing called despite labelAll

seedtag_label

Steps to reproduce

Visit https://www.fupa.net/league/bundesliga on a mobile device. The label is logged as:

const labels = getCustomLabels(); console.log('Labels:', labels);

Expected results

seedtag not beeing called when the label is not 'sod_true'

Actual results

seedtag beeing called although labelAll doesn't match the actual provided label

Platform details

Prebid v8.39.0

Chrome

Mobile device (simulated iPhone)

@dgirardi
Copy link
Collaborator

dgirardi commented Jul 2, 2024

Since version 8, labels require the sizeMapping module. It looks like we fail to mention it in our docs.

@dgirardi
Copy link
Collaborator

dgirardi commented Jul 2, 2024

There may also be a regression - the sizeMapping module is only activated on setConfig({sizeConfig: ...}) - I think 7 may have allowed just "manual" labeling (I'll investigate further). A dummy setConfig({sizeConfig: []}) may work to activate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants