Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow triggering metrics on delegator states. #210

Open
hodgestar opened this issue Oct 22, 2014 · 3 comments
Open

Allow triggering metrics on delegator states. #210

hodgestar opened this issue Oct 22, 2014 · 3 comments

Comments

@hodgestar
Copy link
Contributor

Currently one can't trigger metrics helper metrics on delegator states because those don't have events fired. This is a thorny problem and I'm not entirely sure what the solution is.

@justinvdm
Copy link
Contributor

I'm probably missing some use case, but why would someone want to measure something about a state that doesn't technically exist? For example, if you have a delegate state that delegates to a 'registered' state if someone is registered and a 'register' state if someone isn't registered, you'd maybe want to count the number of people reaching either of those, but I'm not sure why someone would want to count the thing that delegates to them.

@rudigiesler
Copy link
Collaborator

For timing metrics, you might want to know how long a user takes to complete a report. It's then easier to start the timer at the delegation state, than to have multiple metrics for each path that the delegation state delegates to. It also means one metric in the dashboard instead of multiple.

@justinvdm
Copy link
Contributor

Ah, there's the use case I was missing, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants