This repository has been archived by the owner on Jun 12, 2018. It is now read-only.
Implement a metrics resource using Vumi blinkenlights metrics publishers. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if isinstance(user_account, basestring): | ||
| user_account_key = user_account | ||
| else: | ||
| user_account_key = user_account.key |
There was a problem hiding this comment.
Do we really need to accept both of these here? I'd prefer to have the caller extract the key if necessary.
There was a problem hiding this comment.
I don't really mind -- I was just trying to fit in with publish_conversation_metric which takes a conversation but not require people to look up the account if they only have the key.
…ric (first argument is now the user account key).
ghost
assigned 
|
👍 |
|
This replaced #121. |
| def _test_error(self, cmd, expected_error): | ||
| with LogCatcher() as lc: | ||
| reply = self.resource.handle_fire(self.dummy_api, cmd) | ||
| self.assertEqual(lc.messages(), [expected_error]) |
There was a problem hiding this comment.
Because we use log.warning to log the error. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.