This repository has been archived by the owner on Jun 12, 2018. It is now read-only.
Add metrics resource to Go sandbox #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
We could do this via Holodeck. We'd need to add Twisted client support to photon (https://github.com/shaunsephton/photon/blob/master/photon/client.py) and dashboard API keys to Holodeck (shaunsephton/holodeck#19). |
| def _process_event_command(self, etype, user_account_key, command): | ||
| try: | ||
| event = self._event_for_command(etype, command) | ||
| except Exception, e: |
|
This pull-request is being deprecated in favour of #134 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that JS apps can publish and update metrics.
Its not quite clear what this should look like yet. One option is to expose the metrics stuff relatively directly but that's probably not that useful so there might need to be an intervening layer that does some aggregation.