Enable sentry caching to avoid sentry writing outside of game directory #31417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
enable-sentry-caching
branch
2 times, most recently
from
88e3fda to
3a0a265
Compare
frenzibyte
reviewed
Jan 4, 2025
peppy
force-pushed
the
enable-sentry-caching
branch
from
3a0a265 to
0b21f49
Compare
See ppy#31412. Probably safe enough.
peppy
force-pushed
the
enable-sentry-caching
branch
from
31ef80e to
6b524ab
Compare
|
Test failures need addressing. |
|
Seems the framework android build failed once more: https://github.com/ppy/osu-framework/actions/runs/13013778518/job/36297705258 |
Update framework
peppy
force-pushed
the
enable-sentry-caching
branch
from
f8fa5ec to
fd1d90c
Compare
|
Looks better now, force pushed the framework bump. |
bdach
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two options to avoid pollution of random folders by sentry: disable caching, or provide a sane cache location. Disabling the caching seems like a bad idea, as it uses this as a staging area for sending previous execution captured events that may not be sent yet, in addition to caching.
Gamefor logging setup purposes osu-framework#6493SetupLoggingnot being called in game test scenario osu-framework#6504