Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invisible hit circles #31200

Closed
fewizz opened this issue Dec 19, 2024 · 6 comments · Fixed by #31254
Closed

Invisible hit circles #31200

fewizz opened this issue Dec 19, 2024 · 6 comments · Fixed by #31254
Assignees
@peppy
Labels
area:skinning priority:0 Showstopper. Critical to the next release.

Comments

@fewizz
Copy link

fewizz commented Dec 19, 2024 •
edited
Loading

Type

Game behaviour

Bug description

After update (from 2024.1208.0 to 2024.1219.2), skin hit circles became invisible.

Skin in question (file extension was changed from osk to zip):
Dar_Bojiy_v1.6(Haenes).zip

Screenshots or videos

2024.1219.2:
image

2024.1208.0:
image

Version

2024.1219.2

Logs

compressed-logs.zip
@Joehuu
Copy link
Member

Joehuu commented Dec 19, 2024

The skin didn't finish uploading. Please reupload.

@Joehuu Joehuu added the missing details Can't move forward without more details from the reporter label Dec 19, 2024
@fewizz
Copy link
Author

fewizz commented Dec 19, 2024

The skin didn't finish uploading. Please reupload.

Fixed the link.

@Joehuu
Copy link
Member

Joehuu commented Dec 19, 2024 •
edited
Loading

This regressed in #31052.

Another skin to test, provided in a discord message: https://drive.google.com/file/d/1nX41NTvT5venTA722xAcDL3dIQTyMVf6/view

@Joehuu Joehuu added area:skinning and removed missing details Can't move forward without more details from the reporter labels Dec 19, 2024
@Anczak
Copy link

Anczak commented Dec 19, 2024

I have the same issue with hitcircle but it's the border that is invisible
obraz

@Joehuu
Copy link
Member

Joehuu commented Dec 20, 2024 •
edited
Loading

Another report: https://osu.ppy.sh/comments/3426726

Gonna put this as priority 0 because at least 3 users are experiencing this.

@Joehuu Joehuu added the priority:0 Showstopper. Critical to the next release. label Dec 20, 2024
@EgorBogdanov
Copy link

Just rename hitcircleoverlay-1 to hitcircleoverlay

@peppy peppy self-assigned this Dec 23, 2024
peppy added a commit to peppy/osu that referenced this issue Dec 24, 2024
@peppy
Fix legacy hitcircle fallback logic being broken with recent fix
b8d6bba 
I was a bit too eager to replace all calls with the new `provider`
in
ppy@dae380b,
while it doesn't actually make sense.

To handle the case that was trying to be fixed, using the `provider` to
check whether the *prefix* version of the circle sprite is available is
enough alone.

Closes ppy#31200
@peppy peppy mentioned this issue Dec 24, 2024
Merged
TheDark98 pushed a commit to TheDark98/osu that referenced this issue Jan 14, 2025
@peppy @TheDark98
Fix legacy hitcircle fallback logic being broken with recent fix
cac2956 
I was a bit too eager to replace all calls with the new `provider`
in
ppy@dae380b,
while it doesn't actually make sense.

To handle the case that was trying to be fixed, using the `provider` to
check whether the *prefix* version of the circle sprite is available is
enough alone.

Closes ppy#31200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppy peppy

Labels
area:skinning priority:0 Showstopper. Critical to the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some hitcircle sprites missing in certain skins since last release peppy/osu
5 participants
@peppy @fewizz @EgorBogdanov @Joehuu @Anczak