Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Wiki page incorrectly states behavior of slider tails #30103

Closed
TechniKris opened this issue Oct 3, 2024 · 1 comment
Closed

GitHub Wiki page incorrectly states behavior of slider tails #30103

TechniKris opened this issue Oct 3, 2024 · 1 comment
Assignees

Comments

@TechniKris
Copy link

Type

Other

Bug description

This isn't about the osu! wiki, it's about this GitHub repository's wiki.
This page https://github.com/ppy/osu/wiki/Anatomy-of-a-slider incorrectly states that:

  • missing a slider tail on stable causes a miss,
  • hitting a slider tail on lazer doesn't increase combo.

The part about stable is clearly incorrect. The part about lazer hasn't been the case for a long time already.
I would've committed a PR, but I'm pretty sure it's not possible to do with GH Wikis.

As for numerical values: (I'm not sure whether my assumption is correct, since there's combo_bonus mentioned, but):

  • slider tail on lazer is listed as awarding 10(SmallTick).

Since #26248 the tail should be listed as awarding 150(SliderTailHit), based on this page https://github.com/ppy/osu/wiki/Scoring

The part about classic mod's issue is still true.

Screenshots or videos

Highlighted incorrect parts in yellow:

image

Version

revision: 6268b27

Logs

compressed-logs.zip
lol

@bdach bdach self-assigned this Oct 4, 2024
@bdach
Copy link
Collaborator

bdach commented Oct 4, 2024

I've updated the page, although not entirely in the way you claim it should be updated, as I'm pretty sure some of your claims were incorrect. That said, we've deeply complicated this stuff (to the degree that it took me half an hour to figure out what the current situation actually is), so if you want to double-check the new version for correctness then by all means.

@bdach bdach closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants