Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the providers, add support for authentication #56

Open
poush opened this issue Oct 14, 2018 · 3 comments
Open

Improve the providers, add support for authentication #56

poush opened this issue Oct 14, 2018 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@poush
Copy link
Owner

poush commented Oct 14, 2018

Currently, providers start with some basic methods by implementing the baseMediaProvider class. What we have to do is to improve the providers on two things:

  1. Conventions: We have to make sure file names are good, conventions are taken care of in files names as well as in the coding style and therefore fix them.

  2. Add Support for authentication: Consider those websites which have the requirement for authentication to access the specific resource requested. Now, we might not be able to automate due to several reasons including CSRF but can we improve the experience. Suppose, the user wants to use Netflix in the H2 app and if the user tries to paste the URL of a specific movie, and we open it as a link then it will be redirected to login page. The issue is that in many cases after login user gets redirected to the home page instead of the original URL. Currently, I don't have the exact solution to this, we have to find one which can enhance the experience.

@poush poush added enhancement New feature or request Hacktoberfest labels Oct 14, 2018
@poush
Copy link
Owner Author

poush commented Oct 14, 2018

Meanwhile, point 2 is being discussed, anyone can take the first one to submit PR.

@saravanan10393
Copy link
Contributor

@poush can we add linting for code style

@poush
Copy link
Owner Author

poush commented Oct 15, 2018

@poush can we add linting for code style

yes and I think LGTM will also work on linter config.

@poush poush added question Further information is requested and removed Hacktoberfest labels Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants