Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassicUPS ain't a pep8 name #5

Open
mw44118 opened this issue Sep 8, 2014 · 3 comments
Open

ClassicUPS ain't a pep8 name #5

mw44118 opened this issue Sep 8, 2014 · 3 comments

Comments

@mw44118
Copy link

mw44118 commented Sep 8, 2014

I hate to be that guy, but pep 8 wants packages to be all lower case

Modules should have short, all-lowercase names. Underscores can be used in the module 
name if it improves readability. Python packages should also have short, all-lowercase
names,although the use of underscores is discouraged.

http://legacy.python.org/dev/peps/pep-0008/#package-and-module-names

But more important than that, thanks so much for writing and pushing up this code! I needed it and you really helped me out.

Matt

@poundifdef
Copy link
Owner

What do you think would be a good interface for importing/instantiating/working with this package?

@mw44118
Copy link
Author

mw44118 commented Oct 22, 2014

I would call it something that emphasizes it is a client for the UPS API. Like maybe upsclient.

What's the story behind "classic"?

@poundifdef
Copy link
Owner

Good question. This organization, Eponym, Inc., makes eyewear for many fashion brands.

Before that, the company only made one line of eyewear, "Classic Specs," giving rise to this eponymous UPS library.

zamberjo referenced this issue in aurestic/ClassicUPS Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants