Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Reporter cannot be used in dev builds #6004

Open
sharon-wang opened this issue Jan 15, 2025 · 0 comments
Open

Issue Reporter cannot be used in dev builds #6004

sharon-wang opened this issue Jan 15, 2025 · 0 comments
Labels
area: builds Issues related to Builds category. bug Something isn't working
Milestone

Comments

@sharon-wang
Copy link
Member

sharon-wang commented Jan 15, 2025

System details:

Positron and OS details:

This was discovered when testing #5981 which is based on the prerelease/2025.01 branch, however, the issue can be reproduced on main (currently @ fe3a53c) as well.

I think we'll need to step through commits from 2bc1b74 and earlier to see when this issue was first introduced. This commit is when we branched from main to create the prerelease/2025.01 branch.

Interpreter details:

Any

Describe the issue:

In dev builds (at least Mac and Windows), the Issue Reporter can be opened, but is blank and an error occurs. It is not possible to send an issue report through the Issue Reporter.

Interestingly, Jonathan noted that when using the debugger to step through the dev build, the Issue Reporter works fine!

Release builds don't have this issue.

mac_dev_issue_reporter.mp4

Steps to reproduce the issue:

  1. Open a dev build of Positron Desktop on Mac or Windows
  2. Click on Help in the top bar, then Report Issue
  3. The Issue Reporter opens, but is blank and an error shows

Expected or desired behavior:

The Issue Reporter should show the issue submission form and no error should occur.

Were there any error messages in the UI, Output panel, or Developer Tools console?

Mac

No errors in the Dev Tools console, but the error notification shows:

Failed to execute 'invoke' on 'CreateHTMLCallback': The provided callback is no longer runnable.

Windows

No notification error, but the Dev Tools console includes:

[main 2025-01-15T15:19:09.119Z] [uncaught exception in main]: Error: Titlebar overlay is not enabled
log.ts:382
[main 2025-01-15T15:19:09.120Z] Error: Titlebar overlay is not enabled
    at AuxiliaryWindow.updateWindowControls (file:///C:/Users/sharon/positron/out/vs/platform/windows/electron-main/windowImpl.js:307:17)
    at AuxiliaryWindow.setWin (file:///C:/Users/sharon/positron/out/vs/platform/windows/electron-main/windowImpl.js:100:22)
    at AuxiliaryWindow.doTryClaimWindow (file:///C:/Users/sharon/positron/out/vs/platform/auxiliaryWindow/electron-main/auxiliaryWindow.js:69:18)
    at AuxiliaryWindow.tryClaimWindow (file:///C:/Users/sharon/positron/out/vs/platform/auxiliaryWindow/electron-main/auxiliaryWindow.js:44:14)
    at App.<anonymous> (file:///C:/Users/sharon/positron/out/vs/platform/auxiliaryWindow/electron-main/auxiliaryWindowsMainService.js:51:33)
    at App.emit (node:events:519:28)
    at n._init (node:electron/js2c/browser_init:2:12818)
    at openGuestWindow (node:electron/js2c/browser_init:2:101599)
    at WebContents.<anonymous> (node:electron/js2c/browser_init:2:89067)
    at WebContents.emit (node:events:519:28)
    at WebContents.callbackTrampoline (node:internal/async_hooks:130:17)
@sharon-wang sharon-wang added area: top bar Issues related to Top Bar category. bug Something isn't working os-macos macOS issue area: builds Issues related to Builds category. and removed os-macos macOS issue area: top bar Issues related to Top Bar category. labels Jan 15, 2025
@juliasilge juliasilge added this to the Future milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: builds Issues related to Builds category. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants