line-height for code?

[cscheid]

It appears to me that bootstrap themes don't appear to allow line-height to be configured for monospace fonts, even though our schema allows it.

Should we disallow that or should we patch the scss? (Or, am I wrong?)

[gadenbuie]

Agreed, let's keep monospace more general (both inline and block-level monospace text) and drop line-height.

[gadenbuie]

let's keep monospace more general (both inline and block-level monospace text)

I take this back, I think color and background-color should apply to inline code blocks (think Quarto's purple inline code) and the rest of the properties should apply to all other content set in monospace type. At that point, why not include line-height for block-level code (<pre><code>).

typography:
  monospace:
    family:
    weight:
    style:
    line-height:      # block code
    color:            # inline code
    background-color: # inline code

That said, if you can can set the colors of inline code, why not block code? An alternative would be to have variants of monospace:

typography:
  monospace:
    family:
    weight:
    style:
  monospace-inline:
    color:
    background-color:
  monospace-block:
    line-height:
    color:
    background-color:

or to make block and inline nested options of monospace:

typography:
  monospace:
    family:
    weight:
    style:
    inline:
      color:
      background-color:
    block:
      line-height:
      color:
      background-color:

bootstrap themes don't appear to allow line-height to be configured for monospace fonts

To circle back to this, I think it's okay for us to also write CSS rules and not just adjust Sass variables. Or for us to plug into Quarto Sass variables (if there happens to be one for code blocks).

[cscheid]

At that point, why not include line-height for block-level code (<pre><code>).

No big reason. But that's not a thing that our current themes control, and I just wanted to flag it in case something similar is happening in bslib. In order for block-level code to have controllable line heights, we'll need actual changes in the themes, and that's not been the case so far for Quarto.

[cscheid]

Quarto will have SCSS and theming support for code line-height. It'd be great if bslib supported the same names.

[gadenbuie]

Closing in favor of #16 which covers this and additional typographic field updates.